@larrydewey @DGonzalezVillal
Thanks in advance ;)

@heavenboy8 These are some good changes. @DGonzalezVillal is working on a PR which will remove the endpoints which are causing issues for CI, so when that gets finished, I will leave another comment on here, you can rebase, and we will review this and pull in your changes.

@heavenboy8 will you rebase and we will review and merge?

Can the commits be squashed before we merge?

@heavenboy8 we are planning on having a release soon, to have this on release, please rebase and squash commits!

friendly ping @larrydewey ,@tylerfanelli and @DGonzalezVillal, I did the rebase and squashed the commits so it's ready to be reviewed. Sorry for the delay.
The Sign-off check fails, I guess it's because I pushed the commits in place of @heavenboy8 , am I right? How to solve this?

friendly ping @larrydewey ,@tylerfanelli and @DGonzalezVillal, I did the rebase and squashed the commits so it's ready to be reviewed. Sorry for the delay. The Sign-off check fails, I guess it's because I pushed the commits in place of @heavenboy8 , am I right? How to solve this?

@ThibsG if you git commit -s then push, does that fix it?

git commit --amend -s

If that doesn't work, you can also add it manually to the git commit message, git commit --amend and then write

Signed-off-by: ...

Thanks! I didn't know -s, only the -S option 😉